Add support for href and target props in EuiBasicTable actions.#1347
Merged
cjcenizal merged 3 commits intoelastic:masterfrom Dec 6, 2018
Merged
Add support for href and target props in EuiBasicTable actions.#1347cjcenizal merged 3 commits intoelastic:masterfrom
cjcenizal merged 3 commits intoelastic:masterfrom
Conversation
chandlerprall
suggested changes
Dec 5, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changelog change requested, otherwise this LGTM
CHANGELOG.md
Outdated
| **Bug fixes** | ||
|
|
||
| - Fixed bug in exporting `CommonProps` in TypeScript definitions ([#1341](https://github.com/elastic/eui/pull/1341)) | ||
| - Added support for `href` and `target` props in `EuiBasicTable` actions ([#1347](https://github.com/elastic/eui/pull/1347)) |
Contributor
There was a problem hiding this comment.
Shouldn't be under bug fixes, this is a feature add.
Contributor
Author
|
@chandlerprall Done. |
cjcenizal
force-pushed
the
bug-basic-table-action-href
branch
from
d451d8c to
4aa4521
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the example to demonstrate the use case.
Checklist